macros.getImpl still return incorrect AST for Sym "XXX:ObjectType"

[jangko]

First of all, I would like to thank you for all improvements since nim-lang/RFCs#176.
Instead of returning nilLit, macros.getImpl now gives us some AST. But unfortunately, the AST is still incorrect.

import macros

macro see(x: type): untyped =
  let z = getType(x)[1]
  let y = getImpl(z)
  debugEcho getType(x).treeRepr
  debugEcho "---"
  debugEcho y.treeRepr

We will use the same macro code above for all examples below.

I'll start with ordinary object:

type
  Tire = object
    code: int

see(Tire)

The result is:

BracketExpr
  Sym "typeDesc"
  Sym "Tire"
---
TypeDef
  Sym "Tire"
  Empty
  ObjectTy
    Empty
    Empty
    RecList
      IdentDefs
        Ident "code"
        Sym "int"
        Empty

Now, we will use ref object:

type
  TireRef = ref Tire

var x: TireRef
type XX = type x[]  # should be equal to `Tire`
see(XX)

output still ok:

BracketExpr
  Sym "typeDesc"
  Sym "Tire"
---
TypeDef
  Sym "Tire"
  Empty
  ObjectTy
    Empty
    Empty
    RecList
      IdentDefs
        Ident "code"
        Sym "int"
        Empty

Last, we will try it with ref/ptr shortcut:

type
  TirePtr = ptr object
    code: int

var z: TirePtr
type ZZ = type z[] # the deref works but the internal representation is somewhat weird
see(ZZ)

the result is still PtrTy, not ObjectTy, and the Sym is incorrect:

BracketExpr
  Sym "typeDesc"
  Sym "TirePtr:ObjectType"  # this already correct
---
TypeDef
  Sym "TirePtr"   # how could Sym "TirePtr:ObjectType" become Sym "TirePtr"?
  Empty
  PtrTy                # `PtrTy` should be removed
    ObjectTy        # we only need this `ObjectTy` part
      Empty
      Empty
      RecList
        IdentDefs
          Ident "code"
          Sym "int"
          Empty

Expected output

BracketExpr
  Sym "typeDesc"
  Sym "TirePtr:ObjectType"
---
TypeDef
  Sym "TirePtr:ObjectType"
  Empty
  ObjectTy
    Empty
    Empty
    RecList
      IdentDefs
        Ident "code"
        Sym "int"
        Empty

getImpl should return the impl of Sym "TirePtr:ObjectType" and not of Sym "TirePtr".
Please fix this inconsistency, it will help us a lot writing sane macro based code.

[jangko]

Thank you for the quick response and fix.
But the PtrTy /RefTy still there, and the test also incomplete.
too quick?