Refactored glances.plugins.ip.PluginModel.update
#2998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariel-anieli
force-pushed
the
ip-model
branch
from
efcb5ae to
3470186
Compare
|
Work in progress. |
ariel-anieli
force-pushed
the
ip-model
branch
18 times, most recently
from
7cf72e4 to
a57010a
Compare
* part of nicolargo#2801 * formatted into a dict; if input method is SNMP, returns default stats * if input method is local, calls `get_stats_for_local_input` * it has three steps: `get_private_ipv4`, `get_first_ipv4`, `get_public_ipv4`. Signed-off-by: Ariel Otilibili <[email protected]>
ariel-anieli
force-pushed
the
ip-model
branch
from
a57010a to
cd5877d
Compare
|
Ready to go; all tests are passing. |
|
Thanks @ariel-anieli ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follows from #2997; closed by mistake.
# make test 2>&1 | grep -Pi '^ok|^fail' OK OK OKAfter:
Before:
Resume
get_stats_for_local_inputget_private_ipv4,get_first_ipv4,get_public_ipv4.