Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored glances.plugins.ip.PluginModel.update #2997

Closed
wants to merge 0 commits into from
Closed

Refactored glances.plugins.ip.PluginModel.update #2997

wants to merge 0 commits into from

Conversation

ariel-anieli
Copy link
Contributor

Description

All tests are passing:

# make test 2>&1 | grep -Pi '^ok|^fail'
OK
OK
OK

After:
Screenshot from 2024-11-01 15-30-40
Before:
Screenshot from 2024-11-01 15-30-54

Resume

  • part of Reduce code complexity #2801
  • formatted into a dict; if input method is SNMP, returns default stats
  • if input method is local, calls get_stats_for_local_input
  • it has three steps: get_private_ipv4, get_first_ipv4, get_public_ipv4.

@ariel-anieli ariel-anieli marked this pull request as draft November 1, 2024 14:37
@ariel-anieli
Copy link
Contributor Author

Work in progress: some tests are failing.

@ariel-anieli ariel-anieli mentioned this pull request Nov 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ariel-anieli