Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract command improvement: collecting values from constants in other package files #355

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+158 −6

test: added testdata for extracting consts from different file

7d0eed8
Select commit
Loading
Failed to load commit list.
Open

Extract command improvement: collecting values from constants in other package files #355

test: added testdata for extracting consts from different file
7d0eed8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 13, 2025 in 1s

75.32% (+0.31%) compared to d096e3f

View this Pull Request on Codecov

75.32% (+0.31%) compared to d096e3f

Details

Codecov Report

Attention: Patch coverage is 85.50725% with 10 lines in your changes missing coverage. Please review.

Project coverage is 75.32%. Comparing base (d096e3f) to head (7d0eed8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
goi18n/extract_command.go 85.50% 6 Missing and 4 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
+ Coverage   75.01%   75.32%   +0.31%     
==========================================
  Files          20       20              
  Lines        2061     2124      +63     
==========================================
+ Hits         1546     1600      +54     
- Misses        452      457       +5     
- Partials       63       67       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov