Extract command improvement: collecting values from constants in other package files #355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a way to use constants as identifiers or other fields, and it works if they are in the same file as the message.
I've run into the problem that if the constants are defined in a different file, it doesn't work.
The problem is that in ast such an object (263 line) will be nil and this requires resolving individually, as I understood from google.
Such values are marked with the format “varname:::unresolved:::pkgname” to be matched with constants from all files.
Changes have been made to the extractor.Visit file, which collects constants from all files targeted by the extractor and then replaces the values in the fields.