Skip to content

Commit

Permalink
[communitybridge#3936,communitybridge#3920] Bug/Approval List Update
Browse files Browse the repository at this point in the history
- Disregarded approved and signed flags when fetching ecla records

Signed-off-by: Harold Wanyama <[email protected]>
nickmango committed May 29, 2023

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
1 parent 4472e37 commit 81c4549
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cla-backend-go/signatures/repository.go
Original file line number Diff line number Diff line change
@@ -1785,6 +1785,8 @@ func getLatestSignatures(signatures []*models.Signature) []*models.Signature {
}
}

log.WithFields(f).Debugf("signature Map: %+v", signatureMap)

for _, signature := range signatureMap {
result = append(result, signature)
}
@@ -1832,8 +1834,6 @@ func (repo repository) GetProjectCompanyEmployeeSignature(ctx context.Context, c

// Check for approved signatures
filter = addAndCondition(filter, expression.Name("signature_reference_id").Equal(expression.Value(employeeUserModel.UserID)), &filterAdded)
filter = addAndCondition(filter, expression.Name("signature_approved").Equal(expression.Value(true)), &filterAdded)
filter = addAndCondition(filter, expression.Name("signature_signed").Equal(expression.Value(true)), &filterAdded)

log.WithFields(f).Debugf("running employee signature query on table: %s", repo.signatureTableName)
expr, err := expression.NewBuilder().WithKeyCondition(condition).WithFilter(filter).WithProjection(buildProjection()).Build()

0 comments on commit 81c4549

Please sign in to comment.