Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-ecla : Existing contributor duplicated when add new approval list #3936

Closed
4 tasks
thakurveerendras opened this issue May 11, 2023 · 7 comments
Closed
4 tasks
Assignees
Labels
bug Something isn't working Regression Issue/Bug related to a previously working feature that is now failing

Comments

@thakurveerendras
Copy link
Contributor

Summary

Existing contributor duplicated when add new approval list

Background

Steps :

  1. Login corporate console
  2. Search & open sun project cla page
  3. Enable auto-ecla options
  4. Get contributorsList count say : 45239
  5. Get approval list count : 300
  6. Now add new approval list

Expected behavior

Now contributorsList count increase to 301 i.e. 45540 , expected 45240

Screenshots

image

Environment

Please complete the following information:

  • Environment:
    • ALL
    • DEV
    • STAGING
    • PROD
@thakurveerendras thakurveerendras added the bug Something isn't working label May 11, 2023
@nickmango nickmango self-assigned this May 12, 2023
@mlehotskylf
Copy link
Contributor

@nickmango what is the latest for this issue? Thanks!

nickmango added a commit to nickmango/easycla that referenced this issue May 25, 2023
- Resolved dynamo query when updating approval list previously having wrong queries for existing eclas

Signed-off-by: Harold Wanyama <[email protected]>
@mlehotskylf
Copy link
Contributor

We have a PR in the review.

nickmango added a commit that referenced this issue May 26, 2023
nickmango added a commit to nickmango/easycla that referenced this issue May 26, 2023
- Added goroutine handler for processing ecla signature check

Signed-off-by: Harold Wanyama <[email protected]>
nickmango added a commit that referenced this issue May 26, 2023
@thakurveerendras
Copy link
Contributor Author

Testing is blocked due to issue #3960
504 error appears when try to add GitHub user under approval list #3960

@thakurveerendras
Copy link
Contributor Author

@nickmango
Tested issue on dev site & found that it working fine when we add new user under approval list but count increase by 1 when we delete existing records from approval list , Kindly review this case

@thakurveerendras thakurveerendras added the Regression Issue/Bug related to a previously working feature that is now failing label May 26, 2023
nickmango added a commit to nickmango/easycla that referenced this issue May 29, 2023
- Disregarded approved and signed flags when fetching ecla records

Signed-off-by: Harold Wanyama <[email protected]>
nickmango added a commit that referenced this issue May 29, 2023
@nickmango
Copy link
Contributor

@thakurveerendras kindly verify

@thakurveerendras
Copy link
Contributor Author

Tested issue multiple times on dev site with below project & found that reported case above are not reproducible , So updating issue status

Use below steps to verify issue

  1. Get CompanyContributorAcknowledgements total count
  2. Add new GitHub user under approval list ,
    Expected Verified count should be increase by 1
  3. Deleted existing user from approval list,
    Expected: Verified count should remain same
  4. Re-added same user on approval list,
    Expected: Verified count should remain same

@thakurveerendras
Copy link
Contributor Author

Verified issue on production , Duplicate records are not created after apply above steps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Regression Issue/Bug related to a previously working feature that is now failing
Projects
None yet
Development

No branches or pull requests

3 participants