Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tests to work on multiple RT platforms using a configuration file #52

Merged
merged 4 commits into from
Dec 5, 2019

Conversation

rtzoeller
Copy link
Contributor

What does this Pull Request accomplish?

Introduces the notion of a targets.ini file that can be specified per test-class. This file is applied after the overrides, and supports changing the target operating system and hostname.

The file format is shown below for a test class supporting PharLap and Linux on PXI.

[Supported Targets]
PharLap = 10.2.64.14
Linux64PXI = 10.2.64.21

[Active Configuration]
Platform = Linux64PXI

Why should this Pull Request be merged?

To enable running tests on multiple OSes automatically, we want to be able to configure the OS and IP address used by all system definitions in a test class through a single configuration file. By standardizing the name and relative location of this file, we can easily map test classes to configuration files, which is not true today.

The ATS will subsequently be updated to modify the active configuration and hostnames in the targets.ini files during test runs, to iterate through all supported targets.

What testing has been done?

Ran unit tests in the repository.

Updated the NI Synchronization system tests to use the new format and confirmed that they deployed to the correct target, based on the active configuration.

@rtzoeller rtzoeller requested a review from Karl-G1 December 4, 2019 17:09
@rtzoeller rtzoeller requested a review from csjall as a code owner December 4, 2019 17:09
@AndreasStark
Copy link

@rtzoeller I was running into this just last week. Great timing and work!

@niveristand-diff-bot
Copy link
Collaborator

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

VeriStandTestCase.lvclass--AddConfigurationFiles.vi.png

capture

VeriStandTestCase.lvclass--AddTargetsConfigurationFile.vi.png

capture

VeriStandTestCase.lvclass--OpenVeriStandConnection.vi.png

capture

VeriStandTestCase.lvclass--PatchSystemDefinitionFile.vi.png

capture

VeriStandTestCase.lvclass--ReadActiveConfiguration.vi.png

capture

VeriStandTestCase.lvclass--SetMultipleChannelValues.vi.png

capture

VeriStandTestCaseTests.lvclass--testOpenCloseVeriStandConnection.vi.png

capture

VeriStandTestUtilities.lvlib--ApplyTargetConfiguration.vi.png

capture

VeriStandTestUtilities.lvlib--ConvertTargetPlatformToOperatingSystem.vi.png

capture

VeriStandTestUtilities.lvlib--GenerateOverriddenSystemDefinitionFromExplicitOverrides.vi.png

capture

VeriStandTestUtilities.lvlib--ReadTargetsConfigurationFile.vi.png

capture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants