Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Angular code bring up for nimble-rich-text-viewer component #1336

Merged
merged 8 commits into from
Jul 14, 2023
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { NimbleTextAreaModule, NimbleTextFieldModule, NimbleNumberFieldModule, N
import { NimbleTableModule } from '@ni/nimble-angular/table';
import { NimbleTableColumnTextModule } from '@ni/nimble-angular/table-column/text';
import { NimbleTableColumnAnchorModule } from '@ni/nimble-angular/table-column/anchor';
import { NimbleRichTextViewerModule } from '@ni/nimble-angular/rich-text-viewer';
import { AppComponent } from './app.component';
import { CustomAppComponent } from './customapp/customapp.component';
import { HeaderComponent } from './header/header.component';
Expand Down Expand Up @@ -69,6 +70,7 @@ import { HeaderComponent } from './header/header.component';
NimbleTableColumnTextModule,
NimbleTableColumnAnchorModule,
NimbleBannerModule,
NimbleRichTextViewerModule,
RouterModule.forRoot(
[
{ path: '', redirectTo: '/customapp', pathMatch: 'full' },
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,10 @@
<nimble-list-option *ngFor="let item of comboboxItems" [ngValue]="item">{{ item ? item.first : '' }}</nimble-list-option>
</nimble-combobox>
</div>
<div class="sub-container">
<div class="container-label">Rich Text Viewer</div>
<nimble-rich-text-viewer></nimble-rich-text-viewer>
</div>
<div class="sub-container">
<div class="container-label">Spinner</div>
<nimble-spinner aria-label="Loading example content"></nimble-spinner>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"$schema": "../../../../../node_modules/ng-packagr/ng-package.schema.json",
"lib": {
"entryFile": "public-api.ts"
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import { Directive } from '@angular/core';
import type { RichTextViewer } from '@ni/nimble-components/dist/esm/rich-text-viewer';

export type { RichTextViewer };

/**
* Directive to provide Angular integration for the rich text viewer element.
*/
@Directive({
selector: 'nimble-rich-text-viewer'
})

export class NimbleRichTextViewerDirective {

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import { NgModule } from '@angular/core';
import { CommonModule } from '@angular/common';
import { NimbleRichTextViewerDirective } from './nimble-rich-text-viewer.directive';

import '@ni/nimble-components/dist/esm/rich-text-viewer';

@NgModule({
declarations: [NimbleRichTextViewerDirective],
imports: [CommonModule],
exports: [NimbleRichTextViewerDirective]
})
export class NimbleRichTextViewerModule { }
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
export * from './nimble-rich-text-viewer.directive';
export * from './nimble-rich-text-viewer.module';
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import { TestBed } from '@angular/core/testing';
import { NimbleRichTextViewerModule } from '../nimble-rich-text-viewer.module';

describe('Nimble Rich Text Viewer', () => {
describe('module', () => {
beforeEach(() => {
TestBed.configureTestingModule({
imports: [NimbleRichTextViewerModule]
});
});

it('custom element is defined', () => {
expect(customElements.get('nimble-rich-text-viewer')).not.toBeUndefined();
});
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Angular integration for nimble-rich-text-viewer component",
"packageName": "@ni/nimble-angular",
"email": "[email protected]",
"dependentChangeType": "patch"
}