-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Angular code bring up for nimble-rich-text-viewer component #1336
Initial Angular code bring up for nimble-rich-text-viewer component #1336
Conversation
angular-workspace/projects/example-client-app/src/app/customapp/customapp.component.html
Outdated
Show resolved
Hide resolved
...mble-angular/src/directives/rich-text-viewer/tests/nimble-rich-text-viewer.directive.spec.ts
Outdated
Show resolved
Hide resolved
...jects/ni/nimble-angular/src/directives/rich-text-viewer/nimble-rich-text-viewer.directive.ts
Outdated
Show resolved
Hide resolved
angular-workspace/projects/example-client-app/src/app/customapp/customapp.component.html
Outdated
Show resolved
Hide resolved
...r-workspace/projects/ni/nimble-angular/rich-text-viewer/nimble-rich-text-viewer.directive.ts
Show resolved
Hide resolved
angular-workspace/projects/example-client-app/src/app/customapp/customapp.component.html
Show resolved
Hide resolved
@atmgrifter00 and @suseendran-ni this PR is waiting on y'alls reviews |
@rajsite, FYI @suseendran-ni is out of office and he'll be back only by next week. Can we bypass his review as other code owners approved it? |
@vivinkrishna-ni yep, their review was not blocking, notice that the status checks were met. The status checks are approved if there is a minimum of one approver but you should use your best judgement to know if you need to wait for additional approvers. If you are confident that it is possible to merge you are able to do so, no override should be needed. I merged from main and turned on autocomplete but in the future if it's ready to merge and you have required approvals that you are aware of you can merge. |
Pull Request
🤨 Rationale
This PR includes the angular integration for the
nimble-rich-text-viewer
component, and it is intended to make the component available to the Angular application which allows us to get started with the other features of comments dependent on this component.👩💻 Implementation
nimble-rich-text-viewer
.nimble-rich-text-viewer
to the example client app.Note: We will add the input properties and attributes once the support for the markdown parser and other functionality in the component ( #1335) is completed.
🧪 Testing
Added basic unit tests for the directive.
✅ Checklist