Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix accessibility issues in Angular Example app #280

Closed
fredvisser opened this issue Jan 28, 2022 · 6 comments · Fixed by #2346
Closed

Fix accessibility issues in Angular Example app #280

fredvisser opened this issue Jan 28, 2022 · 6 comments · Fixed by #2346
Assignees
@jattasNI
Labels
tech debt

Comments

@fredvisser
Copy link
Contributor

🐛 Bug Report

We should fix all remaining accessibility issues in the Angular Example app, and change the Lighthouse budget to 100% required to pass
@fredvisser fredvisser mentioned this issue Jan 28, 2022
Merged
2 tasks
@m-akinc m-akinc self-assigned this Mar 9, 2022
@m-akinc m-akinc mentioned this issue Mar 9, 2022
Closed
1 task
@m-akinc m-akinc added blocked Blocked on a third-party issue and removed good first issue labels Mar 14, 2022
@m-akinc
Copy link
Contributor

m-akinc commented Mar 14, 2022

I had put up a PR to fix these (#422), but Milan made a good argument that I was mostly just papering over some unresolved questions about how labels should work (specifically for select), and an a11y bug in the FAST select component (microsoft/fast#5725).

Marking this blocked until those issues are resolved.

@nate-ni nate-ni moved this to 🚫 Blocked in Nimble Design System Priorities Sep 7, 2022
@m-akinc m-akinc removed their assignment Nov 9, 2022
@rajsite rajsite mentioned this issue Jun 14, 2023
Closed
21 tasks
@rajsite rajsite mentioned this issue Feb 7, 2024
Merged
1 task
@rajsite rajsite removed the blocked Blocked on a third-party issue label Feb 7, 2024
@rajsite
Copy link
Member

rajsite commented Feb 7, 2024

Removing the blocked tag as I think the current working decision is we own our select and combobox implementations and can improve accessibility ourselves. The score has also dropped lower and likely impacted by more than just those issues.

@jattasNI
Copy link
Contributor

jattasNI commented Mar 7, 2024 •
edited
Loading

Next step is to create issues for each accessibility problem and prioritize them individually. Then we should close this issue: we don't see much value in tracking all these issues together since it's not well scoped and hasn't led to us prioritizing the work.

@jattasNI jattasNI moved this from Backlog to Defined/Ready to Pickup in Nimble Design System Priorities Mar 7, 2024
@m-akinc m-akinc mentioned this issue Jun 10, 2024
Open
6 tasks
@msmithNI msmithNI added the team review Flag issue for team discussion and review label Aug 2, 2024
@msmithNI
Copy link
Contributor

msmithNI commented Aug 2, 2024

Marked as team review since the select/combobox label change is now in, so we can discuss if there's further work to do here.

Lighthouse reports:

@m-akinc
Copy link
Contributor

m-akinc commented Aug 13, 2024

Make sure remaining problems are tracked in separate issues, update the threshold back to 90 and then close this.

@m-akinc m-akinc removed the team review Flag issue for team discussion and review label Aug 13, 2024
@m-akinc m-akinc moved this from Defined/Ready to Pickup to Current Iteration in Nimble Design System Priorities Aug 13, 2024
@jattasNI jattasNI self-assigned this Aug 14, 2024
@jattasNI jattasNI moved this from Current Iteration to In Progress in Nimble Design System Priorities Aug 14, 2024
@jattasNI
Copy link
Contributor

jattasNI commented Aug 14, 2024 •
edited
Loading

Menu header issues are already tracked by #185

I added the table issues to #2285

I filed #2345 for the rich text issue and linked to it from #1288

@jattasNI jattasNI mentioned this issue Aug 14, 2024
Merged
1 task
jattasNI added a commit that referenced this issue Aug 14, 2024
@jattasNI
Update lighthouse accessibility minScore back to 0.9 (#2346)
68e220a 
# Pull Request

## 🤨 Rationale

Resolves #280. Thanks to some recent fixes, the accessibility score for
the Angular app is now back above 0.9 (it's 93%). We'd like to prevent
regressions by ratcheting the `minScore` back to where it was originally
before #1809.

## 👩‍💻 Implementation

`0.8` ➡️ `0.9` in angular example app lighthouse config

## 🧪 Testing

The Lighthouse step passed in the [main / build (push) PR
check](https://github.com/ni/nimble/actions/runs/10394512684/job/28784465522?pr=2346)
and the [Lighthouse report looks
sane](https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1723668148618-11515.report.html).

## ✅ Checklist

<!--- Review the list and put an x in the boxes that apply or ~~strike
through~~ around items that don't (along with an explanation). -->

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jattasNI jattasNI

Labels
tech debt
Projects
Nimble Design System Priorities
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update lighthouse accessibility minScore back to 0.9 ni/nimble
5 participants
@fredvisser @rajsite @m-akinc @jattasNI @msmithNI