Run Lighthouse on multiple example pages #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jattasNI
reviewed
Jan 25, 2022
angular-workspace/projects/example-client-app/src/app/customapp/customapp.component.html
Outdated
Show resolved
Hide resolved
jattasNI
approved these changes
Jan 27, 2022
angular-workspace/projects/example-client-app/src/app/customapp/customapp.component.html
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Jan 27, 2022
angular-workspace/projects/example-client-app/src/app/customapp/customapp.component.html
Outdated
Show resolved
Hide resolved
rajsite
approved these changes
Jan 28, 2022
angular-workspace/projects/example-client-app/src/app/customapp/customapp.component.scss
Outdated
Show resolved
Hide resolved
angular-workspace/projects/example-client-app/src/app/customapp/customapp.component.scss
Outdated
Show resolved
Hide resolved
angular-workspace/projects/example-client-app/src/app/customapp/customapp.component.scss
Outdated
Show resolved
Hide resolved
angular-workspace/projects/example-client-app/src/app/customapp/customapp.component.scss
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Jan 28, 2022
angular-workspace/projects/example-client-app/src/app/app.module.ts
Outdated
Show resolved
Hide resolved
rajsite
approved these changes
Jan 31, 2022
angular-workspace/projects/example-client-app/src/app/customapp/customapp.component.html
Outdated
Show resolved
Hide resolved
angular-workspace/projects/example-client-app/src/app/header/header.component.scss
Show resolved
Hide resolved
angular-workspace/projects/example-client-app/src/app/customapp/customapp.component.scss
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
fixes #274 fixes #273 - Lighthouse was only validating the example login page. This change adds the
customapppage and duplicates most components on the initial tab.👩💻 Implementation
lighthouserc.jsfile to check theloginpage and thecustomapppage.customapppage, so that Lighthouse sees most Nimble Angular components.🧪 Testing
npm run performance&npm run startlocally. Confirmed Lighthouse report on PR build.✅ Checklist