Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook navigation broken on mobile #1639

Closed
rajsite opened this issue Nov 1, 2023 · 2 comments · Fixed by #1812
Closed

Storybook navigation broken on mobile #1639

rajsite opened this issue Nov 1, 2023 · 2 comments · Fixed by #1812
Labels
blocked Blocked on a third-party issue tech debt

Comments

@rajsite
Copy link
Member

rajsite commented Nov 1, 2023

🧹 Tech Debt

Looks like for a bit the navigation in storybook has not worked on mobile. We should report it as an issue in storybook / find if an existing issue has been made.

Context: #1635 (comment)
@rajsite rajsite added tech debt triage New issue that needs to be reviewed labels Nov 1, 2023
@rajsite rajsite mentioned this issue Nov 1, 2023
Merged
1 task
@fredvisser fredvisser mentioned this issue Nov 2, 2023
Closed
@jattasNI jattasNI mentioned this issue Nov 2, 2023
Merged
1 task
@m-akinc m-akinc removed the triage New issue that needs to be reviewed label Nov 8, 2023
@m-akinc m-akinc added the blocked Blocked on a third-party issue label Nov 8, 2023
@m-akinc
Copy link
Contributor

m-akinc commented Nov 8, 2023

Blocked on Storybook bug

@fredvisser
Copy link
Contributor

Looks like it's resolved in the new mobile UI for Storybook 8.0 - storybookjs/storybook#23723

@rajsite rajsite mentioned this issue Feb 8, 2024
Merged
1 task
rajsite pushed a commit that referenced this issue Feb 9, 2024
@m-akinc
Update Storybook to 7.6.13 (#1812)
e68df6d 
# Pull Request

## 🤨 Rationale

Wanted to see if there were any improvements.

## 👩‍💻 Implementation

- Bumped version from 7.4.0 to 7.6.13
- Had to work around an
[issue](storybookjs/storybook#25170) related
to the typing of `withActions` decorator of actions add-on.
~~Re-exporting `withActions` from our Storybook utilities file with a
type that works (based on [comment in related
issue](storybookjs/storybook#22384 (comment)
Now providing type argument to generic `withActions` function.
- Marked docs support disabled in `addon-essentials` since we import
that addon separately (`addon-docs`) so we can configure it. Not sure if
this improves anything, but it doesn't seem to hurt.
- Also fixes #1639

## 🧪 Testing

Ran Storybook. `npm run storybook` seems to get everything ready about
25% faster (40s -> 30s).

## ✅ Checklist

<!--- Review the list and put an x in the boxes that apply or ~~strike
through~~ around items that don't (along with an explanation). -->

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.
@rajsite rajsite moved this from Backlog to Done in Nimble Design System Priorities Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Blocked on a third-party issue tech debt
Projects
Nimble Design System Priorities
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Storybook to 7.6.13 ni/nimble
3 participants
@fredvisser @rajsite @m-akinc