Update fast-foundation dependency #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jattasNI
approved these changes
Nov 2, 2023
rajsite
reviewed
Nov 2, 2023
packages/nimble-components/src/rich-text/editor/testing/rich-text-editor.pageobject.ts
Show resolved
Hide resolved
rajsite
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
The latest version of fast-foundation has fixes for two of our toolbar issues, so this PR pulls in the latest version.
Resolves #1422
Resolves #1423
👩💻 Implementation
Bump version in package file
Update the rich-text-editor page object to adjust for a change in the toolbar code
🧪 Testing
Used storybook to verify that the two toolbar issues are resolved
✅ Checklist