Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/168 Upgrade Vale #170

Merged

Conversation

aidenvaines-bjss
Copy link
Contributor

@aidenvaines-bjss aidenvaines-bjss commented Jul 19, 2024

Description

Upgrades Vale to v3.6 and restructure the vocab directory accordingly, should resolve #168

Context

The version of Vale being used is from Nov 17, 2023 and has some bugs

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@aidenvaines-bjss aidenvaines-bjss changed the title Issue 168 Upgrade Vale Issue/168 Upgrade Vale Jul 19, 2024
Copy link
Contributor

@stefaniuk stefaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefaniuk stefaniuk added this pull request to the merge queue Jul 22, 2024
Merged via the queue into nhs-england-tools:main with commit 81e5f86 Jul 22, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vale issues 'config/vocabularies/words' directory does not exist
2 participants