Vale issues 'config/vocabularies/words' directory does not exist #168
Comments
|
The latest vale container jdkato/vale is 3.6.0, the 2.29.7 pinned release is well over a year old I had vale installed locally so the `scripts/githooks/check-english-usage.sh' script was picking that up over using the container. According to the documentation:https://vale.sh/docs/topics/vocab/
the .tool-versions file does contain this line PR incoming to increase the version and fix the folder structures to be 3.0+ compliant |
<!-- markdownlint-disable-next-line first-line-heading --> ## Description <!-- Describe your changes in detail. --> Upgrades Vale to v3.6 and restructure the vocab directory accordingly, should resolve #168 ## Context <!-- Why is this change required? What problem does it solve? --> The version of Vale being used is from Nov 17, 2023 and has some bugs ## Type of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply. --> - [x] Refactoring (non-breaking change) - [ ] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would change existing functionality) - [x] Bug fix (non-breaking change which fixes an issue) ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. --> - [x] I am familiar with the [contributing guidelines](../docs/CONTRIBUTING.md) - [x] I have followed the code style of the project - [ ] I have added tests to cover my changes - [x] I have updated the documentation accordingly - [ ] This PR is a result of pair or mob programming --- ## Sensitive Information Declaration To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including [PII (Personal Identifiable Information) / PID (Personal Identifiable Data)](https://digital.nhs.uk/data-and-information/keeping-data-safe-and-benefitting-the-public) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter. - [x] I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.
Is there an existing issue for this?
Current Behavior
When CI runs '.github/actions/check-english-usage/action.yaml' action, the command
check=all ./scripts/githooks/check-english-usage.shfails with this error:Expected Behavior
Actual output should look like this:
Steps To Reproduce
make some spelling mistakes in repo. run
check=branch ./scripts/githooks/check-english-usage.shVisible on this internal PR https://github.com/NHSDigital/nhs-notify-internal/actions/runs/9810021470/job/27089235437?pr=61 should you have access
Output
No response
Code of Conduct
Sensitive Information Declaration
The text was updated successfully, but these errors were encountered: