fix(func): merge_agg return nil if empty (lf-edge#2257)

Signed-off-by: Jiyong Huang <[email protected]>
ngjaying · Oct 9, 2023 · 7830a82 · 7830a82
1 parent 25fec97
commit 7830a82
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/internal/binder/function/funcs_agg.go b/internal/binder/function/funcs_agg.go
@@ -136,7 +136,9 @@ func registerAggFunc() {
 						}
 					}
 				}
-				return result, true
+				if len(result) > 0 {
+					return result, true
+				}
 			}
 			return nil, true
 		},

diff --git a/internal/binder/function/funcs_agg_test.go b/internal/binder/function/funcs_agg_test.go
@@ -278,7 +278,7 @@ func TestConcatExec(t *testing.T) {
 	tests := []struct {
 		name   string
 		args   []interface{}
-		result map[string]interface{}
+		result any
 	}{
 		{ // 0
 			name: "concat wildcard",
@@ -312,13 +312,13 @@ func TestConcatExec(t *testing.T) {
 					int64(200),
 				},
 			},
-			result: map[string]interface{}{},
+			result: nil,
 		}, { // 2
 			name: "concat empty",
 			args: []interface{}{
 				[]interface{}{},
 			},
-			result: map[string]interface{}{},
+			result: nil,
 		},
 	}
 	for _, tt := range tests {