Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(func): merge_agg return nil if empty #2257

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Conversation

ngjaying
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02% ⚠️

Comparison is base (330c667) 62.76% compared to head (5994f48) 62.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2257      +/-   ##
==========================================
- Coverage   62.76%   62.74%   -0.02%     
==========================================
  Files         289      289              
  Lines       34644    34646       +2     
==========================================
- Hits        21744    21737       -7     
- Misses      10894    10901       +7     
- Partials     2006     2008       +2     
Files Changed Coverage Δ
internal/binder/function/funcs_agg.go 80.88% <100.00%> (+0.14%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying marked this pull request as ready for review September 14, 2023 05:45
@ngjaying ngjaying requested a review from Yisaer September 14, 2023 05:45
@ngjaying ngjaying merged commit c5a5858 into lf-edge:master Sep 15, 2023
ngjaying added a commit to ngjaying/kuiper that referenced this pull request Oct 9, 2023
ngjaying added a commit that referenced this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants