Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search and replace for imagePullPolicy #2889

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

lucacome
Copy link
Member

Proposed changes

Only replace the values that have a : in the yaml files

Closes #2780

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested a review from a team as a code owner December 12, 2024 01:49
@github-actions github-actions bot added the chore Pull requests for routine tasks label Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.74%. Comparing base (619c127) to head (1cdde37).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2889   +/-   ##
=======================================
  Coverage   89.74%   89.74%           
=======================================
  Files         109      109           
  Lines       11150    11150           
  Branches       50       50           
=======================================
  Hits        10007    10007           
  Misses       1083     1083           
  Partials       60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sjberman sjberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebasing should fix the pipeline issue. We'll also need to cherry pick this once merged.

@sjberman
Copy link
Contributor

#2902 should fix the pipeline issue seen here

@lucacome lucacome merged commit 4cd0621 into nginxinc:main Dec 13, 2024
42 checks passed
lucacome added a commit to lucacome/nginx-kubernetes-gateway that referenced this pull request Dec 13, 2024
lucacome added a commit that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Improve the release workflow to not edit enum values in values.yaml
3 participants