Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the release workflow to not edit enum values in values.yaml #2780

Closed
salonichf5 opened this issue Nov 18, 2024 · 0 comments · Fixed by #2889
Closed

Improve the release workflow to not edit enum values in values.yaml #2780

salonichf5 opened this issue Nov 18, 2024 · 0 comments · Fixed by #2889
Assignees
Labels
refined Requirements are refined and the issue is ready to be implemented. release-engineering Relates to all release engineering tasks size/small Estimated to be completed within ~2 days
Milestone

Comments

@salonichf5
Copy link
Contributor

salonichf5 commented Nov 18, 2024

Describe the bug
The release workflow needs to be improved to not edit enum fields in values.yaml

To Reproduce
Steps to reproduce the behavior:

  1. Run the release workflow
  2. View the PR, check the values.yaml has correct enum values for images of NGF and NGINX and verify if you see the error in logs enum values cannot be same

Expected behavior
When we run the release workflow, ensure that none of the enum values are replaced when we run the Find and Replace jobs in release workflow.

Your environment

  • Version of the NGINX Gateway Fabric - 1.5.0
  • Version of Kubernetes - 1.25+
  • Kubernetes platform (e.g. Mini-kube or GCP) - KIND
  • Details on how you expose the NGINX Gateway Fabric Pod (e.g. Service of type LoadBalancer or port-forward) - N/A
  • Logs of NGINX container: kubectl -n nginx-gateway logs -l app=nginx-gateway -c nginx
  • NGINX Configuration: kubectl -n nginx-gateway exec <gateway-pod> -c nginx -- nginx -T

Additional context

  • For example: ImagePullPolicy is changed from Always to IfNotPresent
@sjberman sjberman added the release-engineering Relates to all release engineering tasks label Nov 18, 2024
@sjberman sjberman added this to the v2.0.0 milestone Nov 18, 2024
@mpstefan mpstefan added size/small Estimated to be completed within ~2 days refined Requirements are refined and the issue is ready to be implemented. labels Nov 18, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refined Requirements are refined and the issue is ready to be implemented. release-engineering Relates to all release engineering tasks size/small Estimated to be completed within ~2 days
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants