Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing overview in documentation #2235

Closed
wants to merge 1 commit into from

Conversation

miledxz
Copy link
Contributor

@miledxz miledxz commented Jul 13, 2024

Proposed changes

@sjberman @mpstefan This is just a starter for fixing this, if this works good for you guys I can keep going

fixing this issue: #1609

Problem: inconsistencies in documentation

Solution: adding updates

Closes #ISSUE : #1609

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@miledxz miledxz requested review from a team as code owners July 13, 2024 20:28
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 13, 2024
@mjang mjang self-assigned this Jul 15, 2024
@mjang
Copy link
Contributor

mjang commented Jul 15, 2024

Hi @zedGGs . Thanks so much for your contribution! I'm a new NGINX employee, and I'm currently investigating our standards for this issue.

@mjang mjang marked this pull request as draft July 15, 2024 12:51
@mjang
Copy link
Contributor

mjang commented Jul 15, 2024

Moved to draft to prevent accidental merge while I investigate our standards for this issue.

@mjang mjang assigned ADubhlaoich and unassigned mjang Jul 15, 2024
@sjberman
Copy link
Contributor

sjberman commented Jul 15, 2024

@zedGGs Not quite what we're looking for. Take a look at https://github.com/nginxinc/nginx-gateway-fabric/blob/main/site/content/how-to/configuration/control-plane-configuration.md for an example.

The overview section is always at the top to give the introduction of what the purpose of the doc is. There's also a description in the metadata headers. I'll defer to @mjang or @ADubhlaoich to respond with what our docs pattern should be before moving forward on this.

@ADubhlaoich
Copy link
Contributor

Hello @zedGGs! Thanks for opening a PR.

I think the original issue is unclear: for NGINX documentation we use templates based off of The Good Docs Project: the majority of pages are how-to guides.

An overview is intended for the top of the page to summarize its contents for a reader. It doesn't make much logical sense to have it anywhere further down in the page.

We also specifically avoid using the metadata field in our current documentation due to a bug with the Hugo theme.

@travisamartin
Copy link
Contributor

Hello @zedGGs! Thanks for opening a PR.

I think the original issue is unclear: for NGINX documentation we use templates based off of The Good Docs Project: the majority of pages are how-to guides.

An overview is intended for the top of the page to summarize its contents for a reader. It doesn't make much logical sense to have it anywhere further down in the page.

We also specifically avoid using the metadata field in our current documentation due to a bug with the Hugo theme.

Can we add these details to #1609?

@sjberman
Copy link
Contributor

Closing in favor of #2256

@sjberman sjberman closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants