Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for style consistency #2256

Merged
merged 12 commits into from
Jul 25, 2024

Conversation

ADubhlaoich
Copy link
Contributor

@ADubhlaoich ADubhlaoich commented Jul 18, 2024

Proposed changes

This commit updates most of the documentation set to adhere to some contemporary documentation style standards:

  • Sentence case for titles and headings
  • Initial headings for how-to guides as "Overview" and "Before you begin"
  • Moving any frontmatter descriptions to the body of text
  • Removing unnecessary frontmatter data altogether
  • Removing unnecessary custom style tag (Incorporated into the theme by default)

It also collapses a few single document directories (Adding an unnecessary "hop" for users) and re-orders some sections.

Closes #1609

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

This commit updates most of the documentation set to adhere to some
contemporary documentation style standards:

- Sentence case for titles and headings
- Initial headings for how-to guides as "Overview" and "Before you
begin"
- Moving any frontmatter descriptions to the body of text
- Removing unnecessary frontmatter data altogether
@ADubhlaoich ADubhlaoich requested review from a team as code owners July 18, 2024 09:30
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 18, 2024
@ADubhlaoich
Copy link
Contributor Author

pre-commit.ci autofix

@mjang
Copy link
Contributor

mjang commented Jul 18, 2024

Question: why do we add Overview at the start of each page? I don't see it (or "Introduction) at the start of most software documentation

@mjang
Copy link
Contributor

mjang commented Jul 18, 2024

Question: why do we add Overview at the start of each page? I don't see it (or "Introduction) at the start of most software documentation

Oh... I think I see it in the templates.

@ADubhlaoich
Copy link
Contributor Author

pre-commit.ci autofix

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.76%. Comparing base (d76d8eb) to head (c061a53).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2256   +/-   ##
=======================================
  Coverage   87.76%   87.76%           
=======================================
  Files          96       96           
  Lines        6793     6793           
  Branches       50       50           
=======================================
  Hits         5962     5962           
  Misses        774      774           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ADubhlaoich ADubhlaoich requested a review from sjberman July 24, 2024 14:34
@ADubhlaoich
Copy link
Contributor Author

@sjberman Generating the API docs removes the empty line between the Overview and the following paragraph.

No idea how to fix it.

@sjberman
Copy link
Contributor

@ADubhlaoich Oh that's strange...I guess if it doesn't fail the pipeline, then no big deal.

@ADubhlaoich ADubhlaoich merged commit 5b3ac4f into nginxinc:main Jul 25, 2024
37 checks passed
@ADubhlaoich ADubhlaoich deleted the ia-desc-consistency branch July 25, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Inconsistent docs introductions
4 participants