-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add license secret and mgmt config map for r33 #6888
Closed
Closed
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
13fa138
add license secret and mgmt config map
AlexFenlon 84f7b0e
fix typo in dockerfile
AlexFenlon 86367b4
fix lint
AlexFenlon 20a84fb
Merge branch 'main' into feat/add-mgmt-license-and-configmap
AlexFenlon 969b18b
update nginx to 1.27.3 (#6897)
pdabelf5 06a5b68
fix smoke tests and update license logs
AlexFenlon 1d666ee
update license pytest name
AlexFenlon 98ead30
remove s390x
AlexFenlon 35306ee
Merge remote-tracking branch 'refs/remotes/origin/main' into feat/add…
AlexFenlon 14ff120
add unit tests
AlexFenlon e33b549
fix unit test nil pointer
AlexFenlon 41666a3
fix typo in license validation test
AlexFenlon 2f69d22
update wafv5 docs and helm template
vepatel 8cabdf1
update json schema and ci jobs with wafv5 version
vepatel 959fbba
address comment on mgmt config map test and add warning test
AlexFenlon ca458e5
update wafv5 test with enforcer env var
vepatel 21f5129
refactor mgmt configmap tests
AlexFenlon 6d9cf6d
Merge remote-tracking branch 'origin/feat/add-mgmt-license-and-config…
AlexFenlon c1c739b
address comments and fix helm test workflow
AlexFenlon 4440c06
address comment
AlexFenlon 375d599
Merge remote-tracking branch 'refs/remotes/origin/main' into feat/add…
AlexFenlon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var
want
here is alwaysnil
, correct? Am I right that the table tests here contain values that should make theParseMGMTConfigMap
func return error? If that's true, other returned values are irrelevant.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the only way we actually get an error from
ParseMGMTConfigMap
is from the licenseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, if the test inspects the
License
then error should be notnil
. In this example if theerr
==nil
the test fails.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have refactored the test, can we have another review on that please