add license secret and mgmt config map for r33 #6888
Conversation
github-actions
bot
added
enhancement
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6888 +/- ##
==========================================
- Coverage 53.15% 52.96% -0.19%
==========================================
Files 88 88
Lines 20396 20595 +199
==========================================
+ Hits 10842 10909 +67
- Misses 9111 9239 +128
- Partials 443 447 +4 ☔ View full report in Codecov by Sentry. |
internal/configs/configmaps_test.go
Outdated
| if err == nil { | ||
| t.Fatal(err) | ||
| } | ||
| if result.Secrets.License != test.want.Secrets.License { |
There was a problem hiding this comment.
var want here is always nil, correct? Am I right that the table tests here contain values that should make the ParseMGMTConfigMap func return error? If that's true, other returned values are irrelevant.
There was a problem hiding this comment.
Yes, the only way we actually get an error from ParseMGMTConfigMap is from the license
There was a problem hiding this comment.
So, if the test inspects the License then error should be not nil. In this example if the err == nil the test fails.
There was a problem hiding this comment.
We have refactored the test, can we have another review on that please
✅ Deploy Preview will be available once build job completes!
|
…map' into feat/add-mgmt-license-and-configmap
Proposed changes
add initial r33 commit adds license token secret name and mgmt config map.
add app protect 5.4
Checklist
Before creating a PR, run through this checklist and mark each as complete.