Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helm chart issue when set controller.strategy #3106

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

wd
Copy link
Contributor

@wd wd commented Sep 27, 2022

Proposed changes

Fix the helm issue when setting controller.strategy.

#3105

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ciarams87 ciarams87 added the bug An issue reporting a potential bug label Sep 27, 2022
@wd wd force-pushed the dong/fix-helm-generate branch from 2c958c0 to 1ba68a1 Compare September 28, 2022 01:31
@github-actions github-actions bot removed the bug An issue reporting a potential bug label Sep 28, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3106 (2c958c0) into main (fa0f42c) will decrease coverage by 0.15%.
The diff coverage is n/a.

❗ Current head 2c958c0 differs from pull request most recent head 1ba68a1. Consider uploading reports for the commit 1ba68a1 to get more accurate results

@@            Coverage Diff             @@
##             main    #3106      +/-   ##
==========================================
- Coverage   52.39%   52.23%   -0.16%     
==========================================
  Files          58       58              
  Lines       15997    16045      +48     
==========================================
  Hits         8381     8381              
- Misses       7338     7386      +48     
  Partials      278      278              
Impacted Files Coverage Δ
internal/configs/configmaps.go 20.37% <0.00%> (-1.67%) ⬇️
internal/configs/annotations.go 23.07% <0.00%> (-0.93%) ⬇️
internal/configs/parsing_helpers.go 67.64% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wd
Copy link
Contributor Author

wd commented Sep 28, 2022

Should we bump the version number of the chart?

@lucacome
Copy link
Member

@wd no need, we'll bump the chart version at release

@lucacome lucacome added this to the v2.4.0 milestone Sep 28, 2022
@lucacome lucacome merged commit c9ea1e5 into nginxinc:main Sep 28, 2022
@lucacome lucacome added the bug An issue reporting a potential bug label Sep 28, 2022
@lucacome lucacome linked an issue Sep 28, 2022 that may be closed by this pull request
coolbry95 pushed a commit to coolbry95/kubernetes-ingress that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set controller.strategy for the helm chart will cause error
4 participants