Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set controller.strategy for the helm chart will cause error #3105

Closed
wd opened this issue Sep 27, 2022 · 1 comment · Fixed by #3106
Closed

Set controller.strategy for the helm chart will cause error #3105

wd opened this issue Sep 27, 2022 · 1 comment · Fixed by #3106

Comments

@wd
Copy link
Contributor

wd commented Sep 27, 2022

Describe the bug
After setting the controller.strategy in the values file, I'll see this error when running the helm install.

error validating "": error validating data: [apiVersion not set, kind not set]

To Reproduce
Steps to reproduce the behavior:

  1. run helm template --set 'controller.strategy.type=OnDelete' deployments/helm-chart/
  2. You will see a manifest like below. This is not a valid manifest and can't be applied.
---
# Source: nginx-ingress/templates/controller-daemonset.yaml
updateStrategy:
    type: OnDelete

Expected behavior
That manifest should not be generated.

Your environment

  • Version of the Ingress Controller: 2.3.0
  • Version of Kubernetes: 1.20
  • Kubernetes platform: rke
  • Using NGINX or NGINX Plus: Plus

Additional context
I think the issue introduced from this PR #2672.

@github-actions
Copy link

Hi @wd thanks for reporting!

Be sure to check out the docs while you wait for a human to take a look at this 🙂

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants