Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide VS/VSR metrics when CRDs disabled #730

Merged
merged 2 commits into from
Oct 22, 2019
Merged

Hide VS/VSR metrics when CRDs disabled #730

merged 2 commits into from
Oct 22, 2019

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

Prometheus metrics were added in #724

However it doesn't make sense to report number of handled VS/VSR resources in the case that we know CRDs are disabled.

Ingress resource metrics remain exported unconditionally because they are always enabled and handled by the ingress controller.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley self-assigned this Oct 21, 2019
@Dean-Coakley Dean-Coakley added the enhancement Pull requests for new features/feature enhancements label Oct 21, 2019
Rulox
Rulox approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@Rulox Rulox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, lgtm
:shipit:

pleshakov
pleshakov approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Dean-Coakley Dean-Coakley merged commit 108a3d6 into master Oct 22, 2019
@Dean-Coakley Dean-Coakley deleted the hide-vs-metrics branch October 22, 2019 06:47
@pleshakov pleshakov added the bug An issue reporting a potential bug label Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rulox Rulox Rulox approved these changes

@pleshakov pleshakov pleshakov approved these changes

@bvighnesha bvighnesha Awaiting requested review from bvighnesha

@ampant ampant Awaiting requested review from ampant

Assignees

@Dean-Coakley Dean-Coakley

Labels
bug An issue reporting a potential bug enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dean-Coakley @pleshakov @Rulox