Add VS/VSR Prometheus metrics #724
Merged
+89
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dean-Coakley
added
the
enhancement
Dean-Coakley
force-pushed
the
add-vs-prom-metrics
branch
from
604e377 to
ecb479c
Compare
Rulox
suggested changes
Oct 15, 2019
Rulox
approved these changes
Oct 15, 2019
Dean-Coakley
force-pushed
the
add-vs-prom-metrics
branch
from
3420d04 to
78e3b6d
Compare
pleshakov
suggested changes
Oct 16, 2019
There was a problem hiding this comment.
@Dean-Coakley good job! just style consistently/suggestions
pleshakov
approved these changes
Oct 17, 2019
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The IC now exports metrics for the number of VirtualServers and VirtualServerRoutes it is currently handling.
Checklist
Before creating a PR, run through this checklist and mark each as complete.