[cherry-pick] prevent final result from succeeding if any image builds fail #6517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nginx-bot
added
chore
jjngx
approved these changes
Sep 26, 2024
AlexFenlon
approved these changes
Sep 26, 2024
AlexFenlon
deleted the
cherry-pick-release-3.7-76651cc80eec84fa7cc7ffd29c2733996e1ee663
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
There was a logic error in
ci.ymlwhere image builds could fail but the pipeline succeeded due to tests being skipped. This change requires the build stages to pass before the pipeline is marked as good.Checklist
Before creating a PR, run through this checklist and mark each as complete.