Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent final result from succeeding if any image builds fail #6509

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Prevent final result from succeeding if any image builds fail #6509

merged 2 commits into from
Sep 26, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Sep 25, 2024 •
edited
Loading

Proposed changes

There was a logic error in ci.yml where image builds could fail but the pipeline succeeded due to tests being skipped. This change requires the build stages to pass before the pipeline is marked as good.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner September 25, 2024 15:38
@github-actions github-actions bot added github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels Sep 25, 2024
@pdabelf5 pdabelf5 added the needs cherry pick Cherry pick this PR into a release branch label Sep 26, 2024
@pdabelf5 pdabelf5 enabled auto-merge (squash) September 26, 2024 09:30
@pdabelf5 pdabelf5 merged commit 76651cc into main Sep 26, 2024
79 checks passed
@pdabelf5 pdabelf5 deleted the pipeline-failures branch September 26, 2024 09:54
nginx-bot pushed a commit that referenced this pull request Sep 26, 2024
@pdabelf5 @web-flow
prevent final result from succeeding if any image builds fail (#6509)
f2ad309
@pdabelf5 pdabelf5 removed github_actions Pull requests that update Github_actions code needs cherry pick Cherry pick this PR into a release branch labels Dec 16, 2024
@pdabelf5 pdabelf5 changed the title prevent final result from succeeding if any image builds fail Prevent final result from succeeding if any image builds fail Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pdabelf5 @j1m-ryan @AlexFenlon