Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support page #6467

Merged
merged 32 commits into from
Sep 26, 2024
Merged

Added Support page #6467

merged 32 commits into from
Sep 26, 2024

Conversation

mrajagopal
Copy link
Contributor

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Sep 20, 2024
Copy link

github-actions bot commented Sep 20, 2024

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@mrajagopal
Copy link
Contributor Author

I have hereby read the F5 CLA and agree to its terms

mrajagopal and others added 2 commits September 20, 2024 14:06
* Include information on nginx-supportpkg-for-k8s tool
* Provide links to various support channels
@mrajagopal mrajagopal force-pushed the mrajagopal-supportpkg-docs branch from 45eded8 to 83528ff Compare September 20, 2024 02:06
@mrajagopal mrajagopal linked an issue Sep 20, 2024 that may be closed by this pull request
1 task
@mrajagopal mrajagopal marked this pull request as ready for review September 20, 2024 02:27
@mrajagopal mrajagopal requested review from a team as code owners September 20, 2024 02:27
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM though I have a lot of edit suggestions.

Blocking this for merge because there is one change not included I could not cover in an edit suggestion: all of the weights for the other pages need to be updated if this is intended to bt at the very top. The second page should have its weight changed to 200, the third to 300 and so forth.

docs/content/troubleshooting/troubleshoot-support.md Outdated Show resolved Hide resolved
docs/content/troubleshooting/troubleshoot-support.md Outdated Show resolved Hide resolved
docs/content/troubleshooting/troubleshoot-support.md Outdated Show resolved Hide resolved
docs/content/troubleshooting/troubleshoot-support.md Outdated Show resolved Hide resolved
docs/content/troubleshooting/troubleshoot-support.md Outdated Show resolved Hide resolved
docs/content/troubleshooting/troubleshoot-support.md Outdated Show resolved Hide resolved
docs/content/troubleshooting/troubleshoot-support.md Outdated Show resolved Hide resolved
docs/content/troubleshooting/troubleshoot-support.md Outdated Show resolved Hide resolved
docs/content/troubleshooting/troubleshoot-support.md Outdated Show resolved Hide resolved
Co-authored-by: Alan Dooley <[email protected]>
Signed-off-by: Madhu Rajagopal <[email protected]>
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 5 existing pages in this section: with the new document there should be changes in for all 5.

* Previous commit mistakenly changed the weights resulting in different order
* This commit restores the order with the new page, Commercial Support, being the first
@mrajagopal
Copy link
Contributor Author

There are 5 existing pages in this section: with the new document there should be changes in for all 5.

Apologies @ADubhlaoich, I mess-up the order.
This has been corrected with the latest commit.

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.20%. Comparing base (c099abe) to head (9b61529).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6467      +/-   ##
==========================================
- Coverage   53.21%   53.20%   -0.01%     
==========================================
  Files          85       85              
  Lines       16016    16018       +2     
==========================================
  Hits         8523     8523              
- Misses       7085     7087       +2     
  Partials      408      408              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jjngx jjngx added the needs cherry pick Cherry pick this PR into a release branch label Sep 26, 2024
@jjngx jjngx merged commit 3f47e40 into nginx:main Sep 26, 2024
32 checks passed
jjngx pushed a commit that referenced this pull request Sep 26, 2024
jjngx added a commit that referenced this pull request Sep 26, 2024
@mrajagopal mrajagopal deleted the mrajagopal-supportpkg-docs branch September 26, 2024 21:04
@pdabelf5 pdabelf5 changed the title Docs: Added Support page Added Support page Dec 16, 2024
@pdabelf5 pdabelf5 removed the needs cherry pick Cherry pick this PR into a release branch label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add support page to troubleshooting section
7 participants