-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Support page #6467
Added Support page #6467
Conversation
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
I have hereby read the F5 CLA and agree to its terms |
* Include information on nginx-supportpkg-for-k8s tool * Provide links to various support channels
for more information, see https://pre-commit.ci
45eded8
to
83528ff
Compare
Co-authored-by: Jodie Putrino <[email protected]> Signed-off-by: Madhu Rajagopal <[email protected]>
Co-authored-by: Jodie Putrino <[email protected]> Signed-off-by: Madhu Rajagopal <[email protected]>
Co-authored-by: Jodie Putrino <[email protected]> Signed-off-by: Madhu Rajagopal <[email protected]>
Co-authored-by: Jodie Putrino <[email protected]> Signed-off-by: Madhu Rajagopal <[email protected]>
Co-authored-by: Jodie Putrino <[email protected]> Signed-off-by: Madhu Rajagopal <[email protected]>
Co-authored-by: Jodie Putrino <[email protected]> Signed-off-by: Madhu Rajagopal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM though I have a lot of edit suggestions.
Blocking this for merge because there is one change not included I could not cover in an edit suggestion: all of the weights for the other pages need to be updated if this is intended to bt at the very top. The second page should have its weight changed to 200, the third to 300 and so forth.
Co-authored-by: Alan Dooley <[email protected]> Signed-off-by: Madhu Rajagopal <[email protected]>
Co-authored-by: Alan Dooley <[email protected]> Signed-off-by: Madhu Rajagopal <[email protected]>
Co-authored-by: Alan Dooley <[email protected]> Signed-off-by: Madhu Rajagopal <[email protected]>
Co-authored-by: Alan Dooley <[email protected]> Signed-off-by: Madhu Rajagopal <[email protected]>
Co-authored-by: Alan Dooley <[email protected]> Signed-off-by: Madhu Rajagopal <[email protected]>
Co-authored-by: Alan Dooley <[email protected]> Signed-off-by: Madhu Rajagopal <[email protected]>
Co-authored-by: Alan Dooley <[email protected]> Signed-off-by: Madhu Rajagopal <[email protected]>
Co-authored-by: Alan Dooley <[email protected]> Signed-off-by: Madhu Rajagopal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 5 existing pages in this section: with the new document there should be changes in for all 5.
* Previous commit mistakenly changed the weights resulting in different order * This commit restores the order with the new page, Commercial Support, being the first
Apologies @ADubhlaoich, I mess-up the order. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6467 +/- ##
==========================================
- Coverage 53.21% 53.20% -0.01%
==========================================
Files 85 85
Lines 16016 16018 +2
==========================================
Hits 8523 8523
- Misses 7085 7087 +2
Partials 408 408 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Madhu Rajagopal <[email protected]>
Proposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).
Checklist
Before creating a PR, run through this checklist and mark each as complete.