Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link #4477

Closed
wants to merge 1 commit into from
Closed

Fix broken link #4477

wants to merge 1 commit into from

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Oct 5, 2023

Proposed changes

This PR fixes a broken link in the examples dir.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner October 5, 2023 12:56
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Oct 5, 2023
@jjngx jjngx self-assigned this Oct 5, 2023
@jjngx jjngx linked an issue Oct 5, 2023 that may be closed by this pull request
@jjngx jjngx requested review from vepatel, a team, ADubhlaoich, haywoodsh and shaun-nx October 5, 2023 12:57
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #4477 (8dc3837) into main (2e19db8) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4477      +/-   ##
==========================================
- Coverage   51.97%   51.95%   -0.03%     
==========================================
  Files          59       59              
  Lines       16956    16956              
==========================================
- Hits         8813     8809       -4     
- Misses       7848     7850       +2     
- Partials      295      297       +2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lucacome
Copy link
Member

lucacome commented Oct 5, 2023

Isn't this a duplicate of #4472 ?

@jjngx jjngx requested a review from a team October 5, 2023 14:25
@jjngx jjngx closed this Oct 5, 2023
@lucacome lucacome deleted the docs/examples-link-fix branch October 5, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update README linking to correct complete example
3 participants