Issue 4471: Update README linking to correct complete example #4472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The link to the complete-example is broken in the readme at this link: https://github.com/nginxinc/kubernetes-ingress/blob/main/examples/custom-resources/basic-configuration/README.md The README link to "complete example" now points to: https://github.com/nginxinc/kubernetes-ingress/tree/main/examples/ingress-resources/complete-example
Codecov Report
@@ Coverage Diff @@
## main #4472 +/- ##
=======================================
Coverage 51.97% 51.97%
=======================================
Files 59 59
Lines 16956 16956
=======================================
Hits 8813 8813
Misses 7848 7848
Partials 295 295 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
hi @mrajagopal , thank you for your PR. Could you please fix the markdown listing issue? You need to make sure that the line in your editor is not longer than 120 char. |
jjngx
approved these changes
Oct 5, 2023
shaun-nx
reviewed
Oct 5, 2023
shaun-nx
approved these changes
Oct 5, 2023
Co-authored-by: Shaun <[email protected]> Signed-off-by: Madhu Rajagopal <[email protected]>
for more information, see https://pre-commit.ci
|
Thanks for the feedback. As best practise, in future, do I 'update branch' or 'update with rebase' for the merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The link to the complete-example is broken in the readme at this link: https://github.com/nginxinc/kubernetes-ingress/blob/main/examples/custom-resources/basic-configuration/README.md
The README link to "complete example" now points to: https://github.com/nginxinc/kubernetes-ingress/tree/main/examples/ingress-resources/complete-example
Checklist
Before creating a PR, run through this checklist and mark each as complete.