Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip trailing whitespace from TARGET variable #4079

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

ciarams87
Copy link
Contributor

Proposed changes

Strip trailing whitespace from TARGET variable. The extra whitespace is causing the ifeq condition to never be true.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ciarams87 ciarams87 requested a review from a team as a code owner July 5, 2023 10:04
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@github-actions github-actions bot added the bug An issue reporting a potential bug label Jul 5, 2023
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@jjngx jjngx requested review from shaun-nx and a team July 5, 2023 10:07
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #4079 (5620b6d) into main (27e574b) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4079      +/-   ##
==========================================
- Coverage   51.87%   51.84%   -0.03%     
==========================================
  Files          59       59              
  Lines       16710    16710              
==========================================
- Hits         8668     8664       -4     
- Misses       7745     7747       +2     
- Partials      297      299       +2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ciarams87 ciarams87 merged commit d88c475 into main Jul 5, 2023
@ciarams87 ciarams87 deleted the fix/makefile-target-var branch July 5, 2023 10:18
@lucacome lucacome added chore Pull requests for routine tasks and removed bug An issue reporting a potential bug labels Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants