Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick troubleshooting documentation from main branch #4078

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

ADubhlaoich
Copy link
Contributor

@ADubhlaoich ADubhlaoich commented Jul 4, 2023

Proposed changes

This commit cherry-picks the documentation changes merged into main as part of commit 27e574b.

Currently, the live website appears to have missing documentation because of drift between the main branch and the release branch. Once this has been merged, I will redeploy the documentation website to disseminate the change.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

* Updatng troubleshooting document

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Updating troubleshooting section guides

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Apply suggestions from code review

Co-authored-by: Luca Comellini <[email protected]>
Signed-off-by: Jason Williams - NGIИX <[email protected]>

* Update docs/content/troubleshooting/troubleshoot-ingress-controller.md

Co-authored-by: Luca Comellini <[email protected]>
Signed-off-by: Jason Williams - NGIИX <[email protected]>

* Update docs/content/troubleshooting/troubleshoot-ingress-controller.md

Co-authored-by: Luca Comellini <[email protected]>
Signed-off-by: Jason Williams - NGIИX <[email protected]>

* Update docs/content/troubleshooting/troubleshoot-ingress-controller.md

Co-authored-by: Luca Comellini <[email protected]>
Signed-off-by: Jason Williams - NGIИX <[email protected]>

* Update docs/content/troubleshooting/troubleshoot-configmap-policy.md

Co-authored-by: Alan Dooley <[email protected]>
Signed-off-by: Jason Williams - NGIИX <[email protected]>

* Update docs/content/troubleshooting/troubleshoot-configmap-policy.md

Co-authored-by: Alan Dooley <[email protected]>
Signed-off-by: Jason Williams - NGIИX <[email protected]>

* Update docs/content/troubleshooting/troubleshoot-ingress-controller.md

Co-authored-by: Alan Dooley <[email protected]>
Signed-off-by: Jason Williams - NGIИX <[email protected]>

* Update docs/content/troubleshooting/troubleshoot-ingress-controller.md

Co-authored-by: Alan Dooley <[email protected]>
Signed-off-by: Jason Williams - NGIИX <[email protected]>

* Update docs/content/troubleshooting/troubleshoot-virtualserver-virtualserverroute.md

Co-authored-by: Alan Dooley <[email protected]>
Signed-off-by: Jason Williams - NGIИX <[email protected]>

* Update docs/content/troubleshooting/troubleshoot-configmap-policy.md

Co-authored-by: Alan Dooley <[email protected]>
Signed-off-by: Jason Williams - NGIИX <[email protected]>

* Update docs/content/troubleshooting/troubleshoot-virtualserver-virtualserverroute.md

Co-authored-by: Alan Dooley <[email protected]>
Signed-off-by: Jason Williams - NGIИX <[email protected]>

* Update docs/content/troubleshooting/troubleshoot-ingress-controller.md

Co-authored-by: Alan Dooley <[email protected]>
Signed-off-by: Jason Williams - NGIИX <[email protected]>

* Update docs/content/troubleshooting/troubleshoot-ingress-controller.md

Co-authored-by: Alan Dooley <[email protected]>
Signed-off-by: Jason Williams - NGIИX <[email protected]>

* Update docs/content/troubleshooting/troubleshoot-ingress-controller.md

Co-authored-by: Alan Dooley <[email protected]>
Signed-off-by: Jason Williams - NGIИX <[email protected]>

* Update docs/content/troubleshooting/troubleshoot-ingress.md

Co-authored-by: Alan Dooley <[email protected]>
Signed-off-by: Jason Williams - NGIИX <[email protected]>

* Apply suggestions from code review

Signed-off-by: Alan Dooley <[email protected]>

* Restructure, rename and rewrite various troubleshooting documents

This commit adds the changes I have made thus far to the troubleshooting
section of NGINX Ingress Controller's documentation: there is more to be
done yet, but I am pushing these changes for others to see.

The product naming is inconsistent, as is the layout of the pages -
often, appropriate markdown is not used where it would make sense to,
and formatting is otherwise missing.

I will continue to update the documentation to fix these instances.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Change instances of names, improve grammar and phrasing.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Remove test content from draft TransportServer document

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Jason Williams - NGIИX <[email protected]>
Signed-off-by: Alan Dooley <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Luca Comellini <[email protected]>
Co-authored-by: Alan Dooley <[email protected]>
Co-authored-by: Alan Dooley <[email protected]>
@ADubhlaoich ADubhlaoich requested a review from a team as a code owner July 4, 2023 14:43
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jul 4, 2023
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@ADubhlaoich ADubhlaoich self-assigned this Jul 4, 2023
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #4078 (9d5cc74) into release-3.2 (6ce07ed) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release-3.2    #4078   +/-   ##
============================================
  Coverage        51.83%   51.83%           
============================================
  Files               59       59           
  Lines            16705    16705           
============================================
  Hits              8659     8659           
  Misses            7747     7747           
  Partials           299      299           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@danielnginx danielnginx requested a review from a team July 4, 2023 15:18
@tomasohaodha tomasohaodha merged commit b9bb0cc into release-3.2 Jul 5, 2023
@tomasohaodha tomasohaodha deleted the pick-troubleshooting-changes branch July 5, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants