-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/OIDC - relaxed OIDC scope validation #3863
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3863 +/- ##
==========================================
- Coverage 51.95% 51.94% -0.02%
==========================================
Files 59 59
Lines 16759 16746 -13
==========================================
- Hits 8707 8698 -9
+ Misses 7756 7748 -8
- Partials 296 300 +4
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Looks like there are unrelated changes, but I think they go away after #3818 is merged? |
This PR updates validation rules for OIDC scope tokens. It makes them conform to the RFC6749 section 3.3. The section lists ranges of allowed characters.
Updated docs no longer list allowed scopes. Only one mandatory scope is , possibly followed by a number of other, user-defined, custom scopes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Proposed changes
This PR introduces following changes:
openid
is required, users can use their own custom scopes\x2b
used internally to separate tokens in scopes)Checklist
Before creating a PR, run through this checklist and mark each as complete.