Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify validators #3818

Merged
merged 6 commits into from
May 8, 2023
Merged

Simplify validators #3818

merged 6 commits into from
May 8, 2023

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Apr 27, 2023

Proposed changes

This PR simplify validation code. Business logic has not changed.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner April 27, 2023 12:04
@github-actions github-actions bot added the chore Pull requests for routine tasks label Apr 27, 2023
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #3818 (1b1264a) into main (1e92ba4) will decrease coverage by 0.46%.
The diff coverage is 98.57%.

@@            Coverage Diff             @@
##             main    #3818      +/-   ##
==========================================
- Coverage   52.40%   51.94%   -0.46%     
==========================================
  Files          59       59              
  Lines       16925    16759     -166     
==========================================
- Hits         8869     8705     -164     
+ Misses       7759     7756       -3     
- Partials      297      298       +1     
Impacted Files Coverage Δ
pkg/apis/configuration/validation/policy.go 91.62% <95.83%> (+0.20%) ⬆️
...g/apis/configuration/validation/transportserver.go 96.37% <97.61%> (-0.44%) ⬇️
pkg/apis/configuration/validation/common.go 100.00% <100.00%> (ø)
...is/configuration/validation/globalconfiguration.go 87.27% <100.00%> (-1.07%) ⬇️
pkg/apis/configuration/validation/virtualserver.go 93.95% <100.00%> (-0.45%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jjngx jjngx merged commit 19b8ad1 into main May 8, 2023
@jjngx jjngx deleted the chore/validators branch May 8, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants