Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support variables in action proxy headers #1158

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

pleshakov
Copy link
Contributor

Proposed changes

This PR adds support for variables in action proxy header. For example:

proxy:
  upstream: coffee
  requestHeaders:
    pass: true
    set:
    - name: client-cert-id
      value: ${ssl_client_i_dn} # using variable
  responseHeaders:
    add:
    - name: upstream-addresses
      value: ${upstream_addr} # using variable
      always: true

Note: docs will be added in a separate PR

@pleshakov pleshakov added the enhancement Pull requests for new features/feature enhancements label Sep 24, 2020
Copy link
Contributor

@Dean-Coakley Dean-Coakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pleshakov pleshakov merged commit 6cb6a80 into master Sep 25, 2020
@pleshakov pleshakov deleted the variables-in-action-proxy-headers branch September 25, 2020 16:11
@pleshakov pleshakov mentioned this pull request Sep 30, 2020
6 tasks
@pleshakov pleshakov mentioned this pull request Oct 13, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants