Release 1.9.0 #1188
Merged
Release 1.9.0 #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dean-Coakley
commented
Oct 13, 2020
5 tasks
lucacome
approved these changes
Oct 13, 2020
pleshakov
reviewed
Oct 13, 2020
There was a problem hiding this comment.
@Dean-Coakley please see my comments and suggestion. Most of them about the changelog.
LorcanMcVeigh
approved these changes
Oct 14, 2020
pleshakov
approved these changes
Oct 14, 2020
There was a problem hiding this comment.
@Dean-Coakley looks good.
I added an extra suggestion for IngressClass and k8s >= 1.18 based on our discussion.
Dean-Coakley
force-pushed
the
r-1.9.0
branch
2 times, most recently
from
2209c98 to
9fa455a
Compare
Bug first appeared in: d893dd0
* Add Grafana dashboard for Plus * Apply suggestions from code review Co-authored-by: Michael Pleshakov <[email protected]> Co-authored-by: Dean Coakley <[email protected]> * Apply suggestions from code review 2 Co-authored-by: Dean Coakley <[email protected]> * Feedback Co-authored-by: Michael Pleshakov <[email protected]> Co-authored-by: Dean Coakley <[email protected]> (cherry picked from commit 030e8fe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Release 1.9.0 includes:
Checklist
Before creating a PR, run through this checklist and mark each as complete.