-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working on IE11 after upgrading to v5 #336
Labels
Comments
One could probably use #314 as a workaround till this issue is fixed properly. |
@kernle32dll apparently I need to set |
@kernle32dll ended up doing this: // Force default defer to `false` until Helmet works out a bug on IE11
// See: https://github.com/nfl/react-helmet/issues/336
Helmet.defaultProps.defer = false; Hacky, but works for now. |
dcsaszar
added a commit
to dcsaszar/react-helmet
that referenced
this issue
Apr 1, 2019
Fixes nfl#336 Inspired by vuejs/vue#4725
tmbtech
pushed a commit
that referenced
this issue
May 2, 2019
Fixes #336 Inspired by vuejs/vue#4725
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
react-helmet@5 uses
requestAnimationFrame
which IE 11 supports but has a weird bug in strict mode (which is turned on automatically when you use es6 modules).Basically it must be either called with
window
context or bound to it or it will throw withInvalid calling object
. See this thread that describes the same bug in vuejs: vuejs/vue#4465 and also their fix to it: ant-design/ant-design@0a9a388#diff-3537c7c5164da1c7f03e6eed0346218fR20.The text was updated successfully, but these errors were encountered: