Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable webpack node stuff, IE/Edge compatible #180

Closed
wants to merge 1 commit into from

Conversation

dcsaszar
Copy link
Contributor

@dcsaszar dcsaszar commented Apr 1, 2019

see #176 and 5c9f833

Workaround for nfl/react-helmet#336 in the spirit of vuejs/vue#4465 (comment).

The issue is caused by a mix of IE/Edge and eval (Webpack hot reloading).
Thus, the responsibility doesn't really lie with Helmet, even though others (Vue) were so kind to implement a workaround.

@dcsaszar
Copy link
Contributor Author

dcsaszar commented Apr 1, 2019

Closing, as discussed in person. Will try to get nfl/react-helmet#336 fixed first.

@dcsaszar dcsaszar closed this Apr 1, 2019
@dcsaszar dcsaszar deleted the dave-webpack-node-false branch April 1, 2019 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant