Updated github actions #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apeltzer
approved these changes
Nov 16, 2020
ewels
added a commit
to ewels/nf-core-smrnaseq
that referenced
this pull request
Nov 16, 2020
ewels
added a commit
to ewels/nf-core-smrnaseq
that referenced
this pull request
Nov 16, 2020
1 task
ewels
added a commit
to ewels/nf-core-methylseq
that referenced
this pull request
Nov 18, 2020
ewels
added a commit
to ewels/nf-core-tools
that referenced
this pull request
Nov 18, 2020
With update to GitHub Actions technote-space/get-diff-action, we need to use env.MATCHED_FILES instead of env.GIT_DIFF to see if any of the files listed under FILES have been changed. env.GIT_DIFF basically always returns true, so currently the Docker image always builds. Docs: https://github.com/marketplace/actions/get-diff-action#examples-of-env Original PR: nf-core#774
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to fix #739
Changed the actions in awstest.yml and awsmegatest.yml to
conda-incubator/setup-miniconda@v2and switched version of
get-diff-action@v1toget-diff-action@v4in ci.yml.Also changed the PREFIX_FILTER to FILES command in ci.yml, because the former is deprecated.
These changes fix the problems of deprecated
set-envcommands in GitHub actions.PR checklist