Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump 1.2.0dev #132

Merged
merged 4 commits into from
Nov 18, 2020
Merged

Bump 1.2.0dev #132

merged 4 commits into from
Nov 18, 2020

Conversation

skrakau
Copy link
Member

@skrakau skrakau commented Nov 18, 2020

Bump 1.2.0dev

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repo

@skrakau skrakau requested a review from d4straub November 18, 2020 09:11
@skrakau
Copy link
Member Author

skrakau commented Nov 18, 2020

Applied changes by @KevinMenden from nf-core/tools#774 to avoid deprecated env usage and get CI tests working again.

Copy link
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Was before already wondering why checks are failing.

@skrakau
Copy link
Member Author

skrakau commented Nov 18, 2020

me too :)

@KevinMenden
Copy link
Contributor

There was an error in the changes I made, you'll have to change the code slightly:
See here:
nf-core/tools#777

Basically exchange env.GIT_DIFF by env.MATCHED_FILES otherwise the docker image gets build all the time

@skrakau
Copy link
Member Author

skrakau commented Nov 18, 2020

Thanks a lot @KevinMenden , was just about to change that :)

@KevinMenden
Copy link
Contributor

Sorry for the inconvenience :)

@skrakau
Copy link
Member Author

skrakau commented Nov 18, 2020

Thanks to you for updating the CI and keeping us informed!

@skrakau skrakau merged commit 98d5aa0 into nf-core:dev Nov 18, 2020
@skrakau skrakau deleted the bump_1.2.0dev_2 branch May 31, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants