Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addedd optional output channel for lib files #5257

Merged
merged 3 commits into from
Mar 19, 2024
Merged

addedd optional output channel for lib files #5257

merged 3 commits into from
Mar 19, 2024

Conversation

alessiovignoli
Copy link
Contributor

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@alessiovignoli
Copy link
Contributor Author

Description:

To the module tcoffee/align has been added the functionality to output library (lib) files. As this is in the capabilities of t_coffee commandline. Such output channel has been set to optional for obvious reasons.

@alessiovignoli alessiovignoli added this pull request to the merge queue Mar 19, 2024
@alessiovignoli alessiovignoli mentioned this pull request Mar 19, 2024
Closed
Merged via the queue into nf-core:master with commit c65917d Mar 19, 2024
11 checks passed
@alessiovignoli alessiovignoli deleted the tcoffe_lib branch March 19, 2024 14:51
famosab pushed a commit to famosab/modules that referenced this pull request Mar 19, 2024
@alessiovignoli @famosab
addedd optional output channel for lib files (nf-core#5257)
b7689e6 
* addedd optional output channel for lib files

* added the output description for lin in meta.yml
jvfe added a commit to jvfe/modules that referenced this pull request Mar 19, 2024
@jvfe
Merge branch 'master' into nf-test_phispy
e16f6f9 
* master:
  Fix test for FASTQ_FASTQC_UMITOOLS_FASTP which included an absolute path in the snapshot. (nf-core#5278)
  added new module lofraq/viterbi; solves new module: lofreq/viterbi nf-core#5158 (nf-core#5197)
  Update glimpse/phase output channel to phased_variants nf-core#5172 (nf-core#5174)
  Add module: GTFSORT (nf-core#5237)
  add nf-test to bedtools/sort - nf-core#3936 (nf-core#5221)
  addedd optional output channel for lib files (nf-core#5257)
vlebars pushed a commit to vlebars/modules that referenced this pull request Mar 20, 2024
@alessiovignoli
addedd optional output channel for lib files (nf-core#5257)
da2ef33 
* addedd optional output channel for lib files

* added the output description for lin in meta.yml
tucano pushed a commit to tucano/modules that referenced this pull request Mar 20, 2024
@alessiovignoli @tucano
addedd optional output channel for lib files (nf-core#5257)
5ec7a80 
* addedd optional output channel for lib files

* added the output description for lin in meta.yml
jennylsmith pushed a commit to RSC-RP/modules that referenced this pull request Mar 20, 2024
@alessiovignoli @jennylsmith
addedd optional output channel for lib files (nf-core#5257)
36f531a 
* addedd optional output channel for lib files

* added the output description for lin in meta.yml
alexnater pushed a commit to alexnater/nf-core-modules that referenced this pull request Mar 21, 2024
@alessiovignoli
addedd optional output channel for lib files (nf-core#5257)
210e55c 
* addedd optional output channel for lib files

* added the output description for lin in meta.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisas luisas luisas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alessiovignoli @luisas