Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove pytest files for bcftools sort #5218

Merged
merged 1 commit into from
Mar 19, 2024
Merged

remove pytest files for bcftools sort #5218

merged 1 commit into from
Mar 19, 2024

Conversation

pawelciurkaardigen
Copy link
Contributor

@pawelciurkaardigen pawelciurkaardigen commented Mar 19, 2024 •
edited
Loading

PR relates to #5192, where bcftools sort test were migrated, but pytest files were not removed.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

mauro-saporita
mauro-saporita approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@mauro-saporita mauro-saporita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@mauro-saporita mauro-saporita added this pull request to the merge queue Mar 19, 2024
Merged via the queue into nf-core:master with commit 6b5178c Mar 19, 2024
9 checks passed
@pawelciurkaardigen pawelciurkaardigen mentioned this pull request Mar 19, 2024
Closed
vlebars pushed a commit to vlebars/modules that referenced this pull request Mar 19, 2024
@pawelciurkaardigen
remove pytest files for bcftools sort (nf-core#5218)
ad48da6
jvfe added a commit to jvfe/modules that referenced this pull request Mar 19, 2024
@jvfe
Merge branch 'master' into fastx_collapser
f7e851f 
* master:
  Added module ALE (nf-core#5211)
  add cram support to bowtie2 (nf-core#5180)
  Add nf-test to minimap2 index (nf-core#5189)
  nf-test all wisecondorx modules (nf-core#5219)
  splitncigarreads added meta for references (nf-core#5224)
  More tests for FASTQ_FASTQC_UMITOOLS_FASTP (nf-core#5179)
  SNPEFF_SNPEFF with nf-test tests (nf-core#5204)
  del extra info from config, passed sing and docker tests (nf-core#5217)
  Added meta map to module and tests (nf-core#5191)
  Nftest htseq (nf-core#5220)
  remove pytest files for `bcftools sort` (nf-core#5218)
  Cellpose: updated to 3.0.1 (nf-core#5193)
  rename taxonomy files in kraken2/add module (nf-core#5214)
  add nf-test to bedtools/merge - nf-core#3936 (nf-core#5203)
tucano pushed a commit to tucano/modules that referenced this pull request Mar 20, 2024
@pawelciurkaardigen @tucano
remove pytest files for bcftools sort (nf-core#5218)
0fe8664
jennylsmith pushed a commit to RSC-RP/modules that referenced this pull request Mar 20, 2024
@pawelciurkaardigen @jennylsmith
remove pytest files for bcftools sort (nf-core#5218)
d03cc93
alexnater pushed a commit to alexnater/nf-core-modules that referenced this pull request Mar 21, 2024
@pawelciurkaardigen
remove pytest files for bcftools sort (nf-core#5218)
c50693a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauro-saporita mauro-saporita mauro-saporita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pawelciurkaardigen @mauro-saporita