Added module ALE #5211
Merged
Added module ALE #5211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itrujnara
reviewed
Mar 19, 2024
There was a problem hiding this comment.
In general it's looking completely fine. Most comments are details. My only concern is that we normally use two different meta inputs only if the module contains multiple tools, otherwise a single meta works for multiple inputs. I would suggest merging the input into a single tuple, i.e. tuple val(meta), path(asm), path(bam). You can use the larger meta, provided the ID will be the same. Feel free to argue if there is a major reason to use two inputs.
itrujnara
approved these changes
Mar 19, 2024
jvfe
added a commit
to jvfe/modules
that referenced
this pull request
Mar 19, 2024
* master: Added module ALE (nf-core#5211) add cram support to bowtie2 (nf-core#5180) Add nf-test to minimap2 index (nf-core#5189) nf-test all wisecondorx modules (nf-core#5219) splitncigarreads added meta for references (nf-core#5224) More tests for FASTQ_FASTQC_UMITOOLS_FASTP (nf-core#5179) SNPEFF_SNPEFF with nf-test tests (nf-core#5204) del extra info from config, passed sing and docker tests (nf-core#5217) Added meta map to module and tests (nf-core#5191) Nftest htseq (nf-core#5220) remove pytest files for `bcftools sort` (nf-core#5218) Cellpose: updated to 3.0.1 (nf-core#5193) rename taxonomy files in kraken2/add module (nf-core#5214) add nf-test to bedtools/merge - nf-core#3936 (nf-core#5203)
tucano
pushed a commit
to tucano/modules
that referenced
this pull request
Mar 20, 2024
* Added ale module * remove test specific config file * fix typo in meta yaml file * conda matplotlib package version fixed * corrections due PR suggestions
jennylsmith
pushed a commit
to RSC-RP/modules
that referenced
this pull request
Mar 20, 2024
* Added ale module * remove test specific config file * fix typo in meta yaml file * conda matplotlib package version fixed * corrections due PR suggestions
alexnater
pushed a commit
to alexnater/nf-core-modules
that referenced
this pull request
Mar 21, 2024
* Added ale module * remove test specific config file * fix typo in meta yaml file * conda matplotlib package version fixed * corrections due PR suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Closes #5138
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda