Dev -> Master 2.4.0 #321
Merged
Dev -> Master 2.4.0 #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump v2.4.0dev
remove unused output folder
To match the template
Important! Template update for nf-core/tools v2.8
Co-authored-by: Edmund Miller <[email protected]>
bump-nf-tests-snapshots-2.8.0
CI-add-pr-comment-if-logic
Fix/maintenance fixes
disable CI PR commenter
bump version 2.4.0
SPPearce
requested changes
Jun 5, 2023
There was a problem hiding this comment.
I don't think that ignore is a suitable name for a parameter, I think it should be ignore_r1. Similarly with ignore_3prime to make it match up.
Generally ok other than that, a few minor points. There are some #TODO strings, I don't know if that is because they are in the template or where they have come from.
SPPearce
approved these changes
Jun 10, 2023
CI-update-skip-dev-condition, update README and changelog
edmundmiller
approved these changes
Jun 12, 2023
fix ignore params help text [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipeline Updates
--bamqc_regions_fileparameter for targeted methylation sequencing data Regions file parameter for Qualimap Bamqc #302new File().exists()and!new File().exists()checkstests/pipeline/UTILS.groovyfor local groovy functions used in testsBug fixes & refactoring
params.test_data_basein test and test_full configs bump-nf-tests-snapshots-2.8.0 #310devtests with NXF_VERlatest-everythingbump-nf-tests-snapshots-2.8.0 #310mastertests with NXF_VER22.10.1&latest-everythingbump-nf-tests-snapshots-2.8.0 #310fail-fastset to false bump-nf-tests-snapshots-2.8.0 #310ignoreandignore_3primeparameters whenignore_r1orignore_3prime_r1are greater than 0. 2.4.0 code review fixes #322ignore->ignore_r1andignore_3prime->ignore_3prime_r1paramsignore_3prime_r2param --ignore_r2 and --ignore_3prime_R2 are not working as intended #299