Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove BUSCO warning about no matches found #442

Merged
merged 3 commits into from
May 11, 2023
Merged

Remove BUSCO warning about no matches found #442

merged 3 commits into from
May 11, 2023

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented May 11, 2023 •
edited
Loading

As this can be expected in some datasets, and can be misleading for users who think their assembly failed (which may not always be the case).

Closes #402

Note should be merged after #441 (accidently branched from that...)

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 linked an issue May 11, 2023 that may be closed by this pull request
remove BUSCO warning from stdout log #402
Closed
@github-actions
Copy link

github-actions bot commented May 11, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit ad919cb

+| ✅ 158 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-05-11 10:07:57

erikrikarddaniel
erikrikarddaniel approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@erikrikarddaniel erikrikarddaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jfy133 jfy133 merged commit 9df6b06 into dev May 11, 2023
@jfy133
Copy link
Member Author

jfy133 commented May 11, 2023

Force merging as it's already passed before and it was just a changelog update

@jfy133 jfy133 deleted the busco-warn-removal branch May 11, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikrikarddaniel erikrikarddaniel erikrikarddaniel approved these changes

@skrakau skrakau Awaiting requested review from skrakau

@d4straub d4straub Awaiting requested review from d4straub

@prototaxites prototaxites Awaiting requested review from prototaxites

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove BUSCO warning from stdout log
2 participants
@jfy133 @erikrikarddaniel