Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Important! Template update for nf-core/tools v2.6 #340

Merged
merged 5 commits into from
Oct 7, 2022
Merged

Important! Template update for nf-core/tools v2.6 #340

merged 5 commits into from
Oct 7, 2022

Conversation

nf-core-bot
Copy link
Member

Version 2.6 of nf-core/tools has just been released with updates to the nf-core template. This automated pull-request attempts to apply the relevant updates to this pipeline.

Please make sure to merge this pull-request as soon as possible, resolving any merge conflicts in the nf-core-template-merge-2.6 branch (or your own fork, if you prefer). Once complete, make a new minor release of your pipeline.

For instructions on how to merge this PR, please see https://nf-co.re/developers/sync.

For more information about this release of nf-core/tools, please see the v2.6 release page.

@nf-core-bot nf-core-bot mentioned this pull request Oct 4, 2022
Closed
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Python linting (black) is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install black: pip install black
  • Fix formatting errors in your pipeline: black .

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up Black in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

@github-actions
Copy link

github-actions bot commented Oct 6, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 8fbded0

+| ✅ 156 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.6
  • Run at 2022-10-06 08:57:36

JoseEspinosa
JoseEspinosa approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@jfy133 jfy133 merged commit e7dc31e into dev Oct 7, 2022
@jfy133 jfy133 deleted the nf-core-template-merge-2.6 branch October 7, 2022 06:22
@jfy133 jfy133 mentioned this pull request Feb 27, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoseEspinosa JoseEspinosa JoseEspinosa approved these changes

@d4straub d4straub Awaiting requested review from d4straub

@skrakau skrakau Awaiting requested review from skrakau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nf-core-bot @JoseEspinosa @jfy133