-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: 2.3.0 #397
Release: 2.3.0 #397
Conversation
Co-authored-by: Daniel Straub <[email protected]>
Post release bump
Important! Template update for nf-core/tools v2.6
Update CHANGELOG after template merge
Bowtie2 local to global alignment for ancient DNA mode for BOWTIE2_ASSEMBLY_ALIGN
Update genome commandline parameter
…-sample rather than per-contig)
Add metaBAT2 mincontig warning
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That are a lot of template changes... maybe we should indeed more often do minor releases right after template updates so that the release PRs are more functional changes.
LGTM.
conda "bioconda::multiqc=1.13" | ||
container "${ workflow.containerEngine == 'singularity' && !task.ext.singularity_pull_docker_container ? | ||
'https://depot.galaxyproject.org/singularity/multiqc:1.13--pyhdfd78af_0' : | ||
'quay.io/biocontainers/multiqc:1.13--pyhdfd78af_0' }" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modules/local/multiqc.nf uses 1.12, is is required to have 2 different versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, you guys still have a 'custom' MultiQC module - this one isn't used, but I've left it in the pipeline to make template merges easier :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just had a couple of commentss
Co-authored-by: Daniel Straub <[email protected]> Co-authored-by: Gisela Gabernet <[email protected]>
This reverts commit 9821515.
Sync BUSCO_PLOT version with BUSCO after version bump
Waiting for a third review from @skrakau then we can go :) |
Co-authored-by: James A. Fellows Yates <[email protected]>
Co-authored-by: Sabrina Krakau <[email protected]>
Changes for release2.3.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @jfy133 :)
v2.3.0 - [XXXX/XX/XX]
Added
Changed
TEMPLATE
(by @jfy133, @d4straub, @skrakau)--enable_conda
. Updated local modules to new conda syntax and updated nf-core modules (by @skrakau)Fixed
--very-sensitive
mode) to prevent soft clipping at the end of reads when running in local mode. (by @maxibor)Dependencies
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).